Skip to content

fix(config): fall back to explicitly installed h3 version#1641

Open
danielroe wants to merge 1 commit intomainfrom
fix/ecosystem-ci-compat
Open

fix(config): fall back to explicitly installed h3 version#1641
danielroe wants to merge 1 commit intomainfrom
fix/ecosystem-ci-compat

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 1, 2026

Open in StackBlitz

npm i https://pkg.pr.new/nuxt/test-utils/@nuxt/test-utils@1641
npm i https://pkg.pr.new/nuxt/test-utils/vitest-environment-nuxt@1641

commit: 47d4e22

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 163d8bf0-7fed-46e2-89d3-6922b6eed4b5

📥 Commits

Reviewing files that changed from the base of the PR and between c608a42 and 47d4e22.

📒 Files selected for processing (1)
  • src/config.ts

📝 Walkthrough

Walkthrough

The getVitestConfigFromNuxt function in src/config.ts was modified to implement a two-step fallback mechanism for resolving h3 package information. The change first attempts to read h3 from Nitro's resolved dependency location (via nitroPath or options.nuxt.options.modulesDir), and if unsuccessful, falls back to reading from the project root directory. This affects the derivation of h3Info, which subsequently determines the test.environmentOptions.nuxt.h3Version value. No public API declarations were altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is empty/incomplete, containing only the PR template checklist without any actual explanation of the changes or motivation. Provide a description explaining the problem being solved and why the h3 version fallback mechanism is needed for ecosystem compatibility.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding fallback logic to resolve the h3 package version from explicitly installed sources.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ecosystem-ci-compat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant