Skip to content

fix(dev): await close hooks on shutdown + warn on hanging processes - #1424

Merged
danielroe merged 1 commit into
mainfrom
fix/hanging-processes
Aug 2, 2026
Merged

fix(dev): await close hooks on shutdown + warn on hanging processes#1424
danielroe merged 1 commit into
mainfrom
fix/hanging-processes

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#32928
resolves #373

📚 Description

this awaits close hooks when shutting down/restarting, and warns if there's a hang.

it can't resolve a pure nitro hang - that would need a change to nitro (todo)

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@danielroe, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 52bdcce9-7684-4ef9-b440-3b2a555e9768

📥 Commits

Reviewing files that changed from the base of the PR and between 9d7ce7a and 2fb8716.

📒 Files selected for processing (11)
  • packages/nuxt-cli/src/commands/dev.ts
  • packages/nuxt-cli/src/dev/index.ts
  • packages/nuxt-cli/src/dev/pool.ts
  • packages/nuxt-cli/src/dev/shutdown.ts
  • packages/nuxt-cli/src/dev/takeover.ts
  • packages/nuxt-cli/src/dev/utils.ts
  • packages/nuxt-cli/src/main.ts
  • packages/nuxt-cli/src/run.ts
  • packages/nuxt-cli/src/utils/hang.ts
  • packages/nuxt-cli/test/unit/hang.spec.ts
  • packages/nuxt-cli/test/unit/pool.spec.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 2, 2026

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1424
    
    npm i https://pkg.pr.new/nuxi@1424
    
    npm i https://pkg.pr.new/@nuxt/cli@1424
    

commit: 2fb8716

@codspeed-hq

codspeed-hq Bot commented Aug 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing fix/hanging-processes (2fb8716) with main (9d7ce7a)

Open in CodSpeed

@danielroe
danielroe added this pull request to the merge queue Aug 2, 2026
Merged via the queue into main with commit f668b74 Aug 2, 2026
23 of 25 checks passed
@danielroe
danielroe deleted the fix/hanging-processes branch August 2, 2026 12:47
@github-actions github-actions Bot mentioned this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuxt does not await for Nitro to close properly before reloading server Show warning if build process is hanging afteer is done

1 participant