Skip to content

Feat/more engine metrics#3856

Open
carpawell wants to merge 2 commits intomasterfrom
feat/more-engine-metrics
Open

Feat/more engine metrics#3856
carpawell wants to merge 2 commits intomasterfrom
feat/more-engine-metrics

Conversation

@carpawell
Copy link
Member

No description provided.

@carpawell carpawell marked this pull request as draft March 2, 2026 07:28
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Drop `logic` object counter, it is hard to maintain.
Add more metrics instead:
- "root" -- user's objects only
- "ts" -- TS-typed objects
- "lock" -- LOCK-typed objects
- "link" -- LINK-typed objects
- "gc" -- number of objects to be removed, includes TS-ed, dropped via control
service and expired objects.

Closes #3740.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the feat/more-engine-metrics branch from 7db491a to 8d72c4d Compare March 4, 2026 03:14
@carpawell carpawell marked this pull request as ready for review March 4, 2026 03:18
@carpawell carpawell self-assigned this Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 71.50396% with 108 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.01%. Comparing base (72d4b6d) to head (8d72c4d).

Files with missing lines Patch % Lines
pkg/local_object_storage/metabase/counter.go 72.89% 22 Missing and 7 partials ⚠️
pkg/local_object_storage/metabase/put.go 69.62% 14 Missing and 10 partials ⚠️
pkg/local_object_storage/metabase/revive.go 55.31% 17 Missing and 4 partials ⚠️
pkg/local_object_storage/metabase/version.go 61.90% 8 Missing and 8 partials ⚠️
pkg/local_object_storage/metabase/metadata.go 78.00% 8 Missing and 3 partials ⚠️
pkg/local_object_storage/metabase/delete.go 80.00% 5 Missing ⚠️
pkg/local_object_storage/metabase/inhume.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3856      +/-   ##
==========================================
+ Coverage   25.77%   26.01%   +0.23%     
==========================================
  Files         670      670              
  Lines       43113    43342     +229     
==========================================
+ Hits        11112    11275     +163     
- Misses      30983    31022      +39     
- Partials     1018     1045      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant