Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
End-rey
force-pushed
the
policer-boost-mode
branch
from
c96b4d5 to
5d8d3d8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3855 +/- ##
==========================================
+ Coverage 25.77% 25.78% +0.01%
==========================================
Files 670 670
Lines 43113 43173 +60
==========================================
+ Hits 11112 11132 +20
- Misses 30983 31021 +38
- Partials 1018 1020 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
reviewed
Mar 3, 2026
End-rey
force-pushed
the
policer-boost-mode
branch
3 times, most recently
from
41d14dc to
7b26cb7
Compare
carpawell
reviewed
Mar 4, 2026
pkg/services/policer/process.go
Outdated
| p.mtx.RUnlock() | ||
| // boostWindowSize is the number of recent batches tracked to compute the | ||
| // current boost multiplier. | ||
| const boostWindowSize = 8 |
Member
There was a problem hiding this comment.
do you have any inspiration why it is not e.g. 100? 8 seems too low to me
Contributor
Author
There was a problem hiding this comment.
I just pulled that number out of thin air. With that size, it would take 5 iterations requiring replication to trigger the boost mode. Maybe it could be increased to 16-32, but 100 seems like too much: it would take 51 iterations with replication to trigger the boost mode, which would be too rare, in my opinion.
roman-khimov
reviewed
Mar 6, 2026
End-rey
force-pushed
the
policer-boost-mode
branch
from
7b26cb7 to
15aeb6a
Compare
When the policer detects missing replicas and triggers replication, it enters "boost mode" and multiplies the object batch size by a configurable boost multiplier for subsequent batches. To avoid premature activation on short-lived outages and premature deactivation during netmap changes, boost mode uses a sliding window of the last 8 batches: the policer enters boost when a strict majority of the window's batches required replication, and leaves it when a strict majority were clean. An equal split keeps the current state unchanged. This significantly speeds up cluster recovery. Add new reloadable config option `policer.boost_multiplier`. Closes #3762. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
roman-khimov
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3762.