Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3830 +/- ##
==========================================
- Coverage 25.83% 25.76% -0.08%
==========================================
Files 669 669
Lines 43074 43287 +213
==========================================
+ Hits 11127 11151 +24
- Misses 30930 31114 +184
- Partials 1017 1022 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
initial-placement
branch
7 times, most recently
from
96f2c39 to
a4553c1
Compare
Contributor
Author
|
rdy overall. The only thing left from me is MaxReplicas tests |
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
cthulhu-rider
force-pushed
the
initial-placement
branch
from
a4553c1 to
f87d1da
Compare
This refactoring will help to support initial placement rules (nspcc-dev/neofs-api#352) which will not apply to system objects. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Such requests are specific, so it's clearer to handle them in a separate branch. Also, avoid undefined field values. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
nspcc-dev/neofs-sdk-go@e6342b6...b703a48. IR performs verification of initial rules against the main ones. CLI supports initial rules specified in JSON file only for now. SN allows such policies to be created, but is not yet able to serve them. This will be supported in future updates. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Except policies with set `max_replicas` which will be supported separately. Requests to such containers are denied for now. Requests with `copies_number` now behave like ones with initial `max_replicas`. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Support `max_replicas` and `prefer_local` settings. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
initial-placement
branch
from
f87d1da to
e605908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.