Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3595 +/- ##
==========================================
- Coverage 26.64% 26.62% -0.02%
==========================================
Files 655 655
Lines 49770 49687 -83
==========================================
- Hits 13263 13231 -32
+ Misses 35463 35415 -48
+ Partials 1044 1041 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
End-rey
force-pushed
the
fix-linter-errors
branch
from
ae25bd4 to
8ae52e8
Compare
End-rey
force-pushed
the
fix-linter-errors
branch
from
8ae52e8 to
8a05444
Compare
Could apply De Morgan's law. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Use the if statement instead of switch. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Could use tagged switch on limit. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Error strings should not end with punctuation or newlines. Error strings should not be capitalized. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Could remove embedded field from selector. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Use fmt.Fprintf(...) instead of Write([]byte(fmt.Sprintf(...))). Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
roman-khimov
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to nspcc-dev/.github#42.