Change renderExtraExportMenuItems to an array of ReactNodes#1205
Open
juhanikat wants to merge 2 commits into
Open
Change renderExtraExportMenuItems to an array of ReactNodes#1205juhanikat wants to merge 2 commits into
juhanikat wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TableView/TableToolBar export-menu extension point so callers can provide multiple extra export items instead of a single one, and updates existing tables to use the new shape.
Changes:
- Change
renderExtraExportMenuItemsfrom a single render function to an array of render functions. - Render the extra export items by iterating the array in
TableToolBar. - Update
SpeciesTable,LocalityTable, andCrossSearchTablecall sites to pass arrays.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/TableView/TableView.tsx | Updates the renderExtraExportMenuItems prop type to support multiple items. |
| frontend/src/components/TableView/TableToolBar.tsx | Updates prop typing and renders multiple extra export menu items. |
| frontend/src/components/Species/SpeciesTable.tsx | Wraps the existing extra export menu item in an array. |
| frontend/src/components/Locality/LocalityTable.tsx | Wraps the existing extra export menu item in an array. |
| frontend/src/components/CrossSearch/CrossSearchTable.tsx | Converts multiple extra export items from a fragment to an array. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.