Skip to content

Replace postman-request with axios #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviadhahami merged 3 commits into from
Mar 10, 2026
Merged

Replace postman-request with axios #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3f41cb
Initial plan
Copilot Mar 10, 2026
21b3915
Replace postman-request with axios
Copilot Mar 10, 2026
c741c04
Address code review: add URL error handling and comment for validateS…
Copilot Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.3

import * as request from "postman-request";
import type { AxiosRequestConfig } from "axios";

declare namespace NodeVault {
interface Option {
Expand Down Expand Up @@ -141,7 +141,7 @@ declare namespace NodeVault {
noCustomHTTPVerbs?: boolean;
pathPrefix?: string;
token?: string;
requestOptions?: request.CoreOptions;
requestOptions?: AxiosRequestConfig;
Copy link

@3repeating 3repeating Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking api change

// previously valid
requestOptions: {
   ca:"Custom ca cert goes here"
}

new code breaks this on a minor revision.

Copy link
Collaborator

@aviadhahami aviadhahami Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!
will revert and fix

}
}

Expand Down
Loading
Loading