crypto: improve accuracy of SubtleCrypto.supports#63104
Open
panva wants to merge 4 commits intonodejs:mainfrom
Open
crypto: improve accuracy of SubtleCrypto.supports#63104panva wants to merge 4 commits intonodejs:mainfrom
panva wants to merge 4 commits intonodejs:mainfrom
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
added
crypto
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63104 +/- ##
=======================================
Coverage 89.65% 89.66%
=======================================
Files 712 712
Lines 220822 220843 +21
Branches 42373 42381 +8
=======================================
+ Hits 197985 198019 +34
+ Misses 14661 14641 -20
- Partials 8176 8183 +7
🚀 New features to boost your workflow:
|
ChALkeR
reviewed
May 4, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
jasnell
reviewed
May 4, 2026
| try { | ||
| return check(operation, algorithm, length); | ||
| } catch { | ||
| return false; |
Member
There was a problem hiding this comment.
Not a huge fan of suppressing errors like this. If this is part of the spec that this method should not throw, a comment here would be good.
jasnell
approved these changes
May 4, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the accuracy of SubtleCrypto.supports() by checking the shared secret output from an ECDH (or ECDH-like) algorithm covers the requested/resolved length.