stream: remove redundant method check from iter.pipeToSync#63099
Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Open
stream: remove redundant method check from iter.pipeToSync#63099Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63099 +/- ##
==========================================
- Coverage 91.49% 89.65% -1.84%
==========================================
Files 360 712 +352
Lines 151674 220507 +68833
Branches 23919 42281 +18362
==========================================
+ Hits 138772 197698 +58926
- Misses 12625 14658 +2033
- Partials 277 8151 +7874
🚀 New features to boost your workflow:
|
aduh95
approved these changes
May 4, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
jasnell
approved these changes
May 4, 2026
Renegade334
added
the
commit-queue
lpinca
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of the writeSync method is already validated by parsePipeToArgs, as per the spec, so this is redundant.