fix: treat ? (Quartz no-value) like * in toHuman#9
Merged
Conversation
A ? field was rendered as a literal value, producing nonsense such as "on day ?" or "on undefined". ? means "no constraint on this field" (Quartz / AWS use it in day-of-month or day-of-week), so it is now normalized to *. "0 0 9 ? * MON" now reads as "at 9am on monday".
merencia
force-pushed
the
fix-tohuman-question
branch
from
ffb66a5 to
785dffc
Compare
merencia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cron with a
?field rendered the?as a literal value, producing nonsense:?is the Quartz / AWS character for "no specific value" (used in day-of-month or day-of-week when the other is set). It means "no constraint on this field", the same as*.Fix
toHumannow normalizes?to*:Checks