feat(workspaces): support min_workspaces for dynamic outputs - #120
Closed
Ashur-D wants to merge 1 commit into
Closed
feat(workspaces): support min_workspaces for dynamic outputs#120Ashur-D wants to merge 1 commit into
Ashur-D wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR, as you pointed on Github yesterday it was a bit of a shortcut to get it working. |
Contributor
|
Implemented in c34d7b9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
min_workspacesconfiguration option (integer from 1 to 64, default 1) to[workspaces].When using dynamic workspaces on an output:
min_workspacesare created.WorkspaceGroup::reconcileDynamic()), empty workspaces with indices< min_workspaces(0-based) are retained rather than pruned.min_workspacescontinue to be dynamically created and destroyed as views open and close.min_workspacestriggerworkspaceInventoryandworkspaceLayoutrefreshes.Motivation
Users who enjoy dynamic workspaces often still want a persistent minimum set of workspaces (e.g. 3, 4, or 5) always available and visible in their status bar, dock, or overview without having to switch completely to static workspace rules.
Type of Change
Related Issue
Testing
tests/unit/config_load.cpp: verifies loading and clamping ofmin_workspaces(clamp to 1 min, 64 max).tests/unit/config_resolve.cpp: verifiesresolveWorkspacesForOutputproduces at leastmin_workspaceson dynamic outputs.tests/unit/config_change.cpp: verifiesConfigEffects::betweenreportsworkspaceInventoryandworkspaceLayoutwhenmin_workspaceschanges.meson test -C build --no-suite umbrielfx(all 35/35 unit tests passed).clang-format.Manual Coverage
Screenshots / Videos
Checklist
SCOPE.md, or its scope was agreed in an issue or on Discord first.CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.Additional Notes
None.