Skip to content

fix: don't change workspace focus on session unlock - #116

Merged
ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
Yocraft-2000:fix/unlock-focus
Sep 4, 2026
Merged

fix: don't change workspace focus on session unlock#116
ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
Yocraft-2000:fix/unlock-focus

Conversation

@Yocraft-2000

Copy link
Copy Markdown
Contributor

Summary

use refocus instead of focusing the last focused window, which causes to switch workspace if the active workspace have no focused window.

Motivation

My issue is #113, when I lock the screen with an empty workspace focused, the focus changes to the last focused window, switching workspace.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging
  • Documentation

Related Issue

Closes #113.

Testing

I only have one monitor so I can't test with multiple outputs, the fix works for me but might break other use cases.

Manual Coverage

  • Tested in a nested Umbriel session
  • Tested in a native Umbriel session
  • Tested with multiple monitors
  • Tested with a scaled output
  • Tested with native Wayland applications
  • Tested with X11 applications through xwayland-satellite
  • Tested with the scrolling layout
  • Tested with the dwindle layout

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • This change fits SCOPE.md, or its scope was agreed in an issue or on Discord first.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format, or this PR has no C++ changes.
  • I ran the relevant build, test, lint, or verification commands, or explained why they were not run.
  • I functionally verified compositor behavior where automated checks are insufficient.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated docs/ and examples/config.toml, or this PR does not change user-facing configuration or behavior.
  • I used canonical names for config keys, IPC actions, paths, and identifiers.

Additional Notes

@ItsLemmy
ItsLemmy merged commit dfeaa6e into noctalia-dev:main Sep 4, 2026
@ItsLemmy

ItsLemmy commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Wrong workspace is focused when unlocking

2 participants