feat(rules): add at_startup matcher - #111
Merged
Merged
Conversation
Contributor
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
match.at_startupthat only applies during the first 60s after starting umbriel.Motivation
The primary motivation is for opening applications on certain tags on boot. While this can be done by using window rules, the rules are permanent and apply to all future instances of an application as well; e.g. all future browser windows are also stuck on workspace 1.
Well behaving applications can work around this by specifying a custom app_id or title, but many applications do not support this, e.g. chrome does not set an app_id for incognito windows, nemo does not support specifying either an app_id or title.
Type of Change
Related Issue
Testing
I've added a unittest for a rule that is applied after 60s.
Manual Coverage
Screenshots / Videos
Checklist
SCOPE.md, or its scope was agreed in an issue or on Discord first.CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.Additional Notes
This is pretty much a direct port of the same functionality in niri: https://niri-wm.github.io/niri/Configuration%3A-Window-Rules.html#at-startup.