Skip to content

feat: add center focused on overflow, rework center_focused setting - #110

Open
Yocraft-2000 wants to merge 2 commits into
noctalia-dev:mainfrom
Yocraft-2000:feat/center-on-overflow
Open

feat: add center focused on overflow, rework center_focused setting#110
Yocraft-2000 wants to merge 2 commits into
noctalia-dev:mainfrom
Yocraft-2000:feat/center-on-overflow

Conversation

@Yocraft-2000

@Yocraft-2000 Yocraft-2000 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Added on_overflow option for the center_focused setting.

center_focused = "never"

accepted values are "never", "always", or "on_overflow".

The on_overflow option will center if it doesn't fit on screen together with the previously focused column.

This is a breaking change, previous config is a bool, now it's a string.

Motivation

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging
  • Documentation

Related Issue

Closes #100.

Testing

just format
just test
just lint

Manual Coverage

  • Tested in a nested Umbriel session
  • Tested in a native Umbriel session
  • Tested with multiple monitors
  • Tested with a scaled output
  • Tested with native Wayland applications
  • Tested with X11 applications through xwayland-satellite
  • Tested with the scrolling layout
  • Tested with the dwindle layout

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • This change fits SCOPE.md, or its scope was agreed in an issue or on Discord first.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format, or this PR has no C++ changes.
  • I ran the relevant build, test, lint, or verification commands, or explained why they were not run.
  • I functionally verified compositor behavior where automated checks are insufficient.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I updated docs/ and examples/config.toml, or this PR does not change user-facing configuration or behavior.
  • I used canonical names for config keys, IPC actions, paths, and identifiers.

Additional Notes

The tests needs to be updated.

@Yocraft-2000
Yocraft-2000 marked this pull request as ready for review September 2, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] center_on_overflow

1 participant