fix(view): uniform rounding rule for main surface and subsurfaces - #109
Open
nikoloc wants to merge 1 commit into
Open
fix(view): uniform rounding rule for main surface and subsurfaces#109nikoloc wants to merge 1 commit into
nikoloc wants to merge 1 commit into
Conversation
Author
|
the sharp edge that can be seen in both screenshots seems to be another issue. i dont have an idea why is happens, but i have seen it in other places |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unified the logic for main surface rounding to match the one used for subsurfaces. main surface should not be rounded unconditionally, since its position in the windows coordinate space may not be at the start, observed in the fastpotify client

Motivation
solves the problem described above

Type of Change
Related Issue
Testing
manually tested with mentioned client, and some other apps, both with and without csd. seems like there are no regressions. did not run the automated tests.
Manual Coverage
Screenshots / Videos
Checklist
SCOPE.md, or its scope was agreed in an issue or on Discord first.CONTRIBUTING.md.just format, or this PR has no C++ changes.docs/andexamples/config.toml, or this PR does not change user-facing configuration or behavior.Additional Notes