Skip to content

feat(screen_recorder): add CPU encoder option - #69

Merged
ItsLemmy merged 1 commit into
noctalia-dev:mainfrom
AdityaKr015:feat/screen-recorder-cpu-encoder
Sep 11, 2026
Merged

ItsLemmy merged 1 commit into
noctalia-dev:mainfrom
AdityaKr015:feat/screen-recorder-cpu-encoder

Conversation

@AdityaKr015

@AdityaKr015 AdityaKr015 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds a video_encoder setting (gpu/cpu, default gpu) to Screen Recorder. Selecting cpu passes -encoder cpu to gpu-screen-recorder, so recording works on GPUs with no hardware video encoder. Because the software encoder supports H.264 only, any other video_codec is forced to h264.

Motivation

For the system which have no hardware video encoding or just want to try cpu encoding.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Related Issue

Closes #45

Testing

  • python3 validate-plugins.py = "Validated 13 plugin manifest(s)." all clean

Manual Coverage

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors

Haven't tested yet

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I self-reviewed the changes.
  • I added or updated translations/en.json, or this PR adds no new user-facing strings.
  • I did not edit non-English translation files unless this PR is explicitly for translation tooling, an import/export sync, or a maintainer-requested locale change.

Additional Notes

@ItsLemmy

Copy link
Copy Markdown
Contributor

Excellent, thanks!

@ItsLemmy
ItsLemmy merged commit 3cf231a into noctalia-dev:main Sep 11, 2026
@AdityaKr015

Copy link
Copy Markdown
Contributor Author

Thanks for the merge

@AdityaKr015
AdityaKr015 deleted the feat/screen-recorder-cpu-encoder branch September 11, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] screen_recorder: add h.264 software encoder

2 participants