Skip to content

feat(github-prs): add configurable GitHub hostname - #595

Closed
adriafarres wants to merge 1 commit into
noctalia-dev:mainfrom
adriafarres:add-github-prs-hostname
Closed

feat(github-prs): add configurable GitHub hostname#595
adriafarres wants to merge 1 commit into
noctalia-dev:mainfrom
adriafarres:add-github-prs-hostname

Conversation

@adriafarres

Copy link
Copy Markdown

Plugin

  • Id: raycursive/github-prs
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Adds a configurable GitHub hostname setting to GitHub Pull Requests. The fetch
service passes the configured hostname to gh api, allowing the plugin to query
GitHub Enterprise as well as GitHub.com. The setting defaults to github.com,
so existing installations keep their current behavior.

External dependencies

gh performs the configured-host API request. xdg-open opens selected pull
requests. Both are already declared in plugin.toml.

Testing

  • Tested on Niri
  • Noctalia version tested against: installed local version
  • Plugin API level: 9

Validated with:

python3 .github/workflows/scripts/validate-plugins.py
noctalia plugins lint github-prs

Also tested the setting against github.azc.ext.hp.com: the service fetched
three matching open pull requests. Removing the setting used the github.com
default and fetched the public-account results successfully.

Screenshots / Videos

No visual-surface changes; this adds a plugin Settings control.

Checklist

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the README template, documents every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This pull request was automatically closed because its description no longer contains
every part of the pull request template
that this repository requires.

Missing:

  • the checklist entry: New plugin
  • the checklist entry: Tested on Hyprland
  • the checklist entry: Tested on Sway
  • the checklist entry: Tested on another compositor:

Please add the items listed above back to the description, keeping their exact wording, then
reopen the pull request. Reopening re-runs this check. Draft pull requests may leave boxes
unchecked. Before a pull request is ready for review, exactly one plugin type, at least one
tested compositor, and every item under Checklist and Code review attestation must be checked.

@github-actions github-actions Bot closed this Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

CC @raycursive — this pull request was automatically moved to draft until you have had a chance to look at it. It will be marked ready for review automatically once you reply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants