Conversation
✅ Deploy Preview for nf-core-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| then { | ||
| assertAll( | ||
| { assert process.success }, |
There was a problem hiding this comment.
Can do as @SPPearce suggested and put the assert process.success before the assertAll?
There was a problem hiding this comment.
I agree, this would be nice.
In the end do we even need the assertAll ?
There was a problem hiding this comment.
not so sure about that either
|
any updates here @famosab? |
|
I'm going to ping @LouisLeNezet here and hope that he is willing to do some work on the docs ;) |
LouisLeNezet
left a comment
There was a problem hiding this comment.
Here is some comments, where things could be further standardized.
This would help to uniformize the modules repository 😉
|
|
||
| then { | ||
| assertAll( | ||
| { assert process.success }, |
There was a problem hiding this comment.
I agree, this would be nice.
In the end do we even need the assertAll ?
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
…est_writing_tests.md Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
| process { | ||
| """ | ||
| input[0] = Channel.fromList([ | ||
| tuple([ id:'test1', single_end:false ], // meta map |
There was a problem hiding this comment.
Should we use tuple( or [
There was a problem hiding this comment.
I tend to remove everything even the Channel statetement
@netlify /docs/tutorials/tests_and_test_data/nf-test_writing_tests