feat: Update types & add support computed#1
Merged
jpkleemans merged 1 commit intonexxtmove:mainfrom Aug 28, 2025
Merged
Conversation
Contributor
|
Hi, thanks for the PR! I've just updated the source code, can you fix the merge conflicts? I've released your |
- Add Combine type - Update Issues type
Contributor
Author
|
Done, I've revert computed commit and force sync with 0.3.2 changes. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First point is correct types for issues.
I just added
Combinetype which concat all options from schema.For example if I use union schema
I got TS error in
issues.password:Because issues has same type as form:
And with Combine type integration we're got issues type like this:
Another one point - using
MaybeRefOrGetterinsteadMaybeRef. This is full backward compatible update but may be useful for specific cases with computed and getters data as form