Skip to content

🗺️ Migrate location picker to composables#5893

Open
AndyScherzinger wants to merge 1 commit intomasterfrom
feat/noid/migrateGeo2
Open

🗺️ Migrate location picker to composables#5893
AndyScherzinger wants to merge 1 commit intomasterfrom
feat/noid/migrateGeo2

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Feb 22, 2026

  • with custom zoom controls and
  • dark mode support (discuss if it should be kept)
  • visual revamp with search bar on top, current location moved to bottom and vertical zoom controls moved to the side on portrait and horizontal on landscape and also replaced the red pin using a different, less aggressive shade of red and a black outline

🖼️ Screenshots

🏚️ Before 🏡 After
before_light Screenshot_20260223_175200
before_dark Screenshot_20260223_175230
before_dark_landscape Screenshot_20260223_175239

🚧 TODO

  • add screenshots
  • max search bar max-width-ed to 720dp as per M3 guide
  • review feedback design/code

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 22, 2026
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews technical debt Technical issue feature: chat 🗨️ feature: theming 🌗 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 22, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateGeo2 branch 4 times, most recently from 73b71d7 to 7b42125 Compare February 22, 2026 19:45
@AndyScherzinger AndyScherzinger changed the title Migrate Location picker to composables 🗺️ Migrate Location picker to composables Feb 22, 2026
@AndyScherzinger AndyScherzinger changed the title 🗺️ Migrate Location picker to composables 🗺️ Migrate location picker to composables Feb 22, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateGeo2 branch 10 times, most recently from 1b0e7e9 to fbdd0be Compare February 23, 2026 13:45
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 23, 2026
@AndyScherzinger
Copy link
Member Author

The dark mode of the map might be debatable @jancborchardt since it interferes with the search bar. I could make that the same color as the bottom element (surface container highest instead or high) while that would not be according to M3 spec, but not an issue per se.

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateGeo2 branch 5 times, most recently from fec00f3 to f2b0b8f Compare February 24, 2026 21:04
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

In landscape mode there could be some space saved by not making the "Share location" box full width but keeping some space for the zoom and location buttons.

If it's according to spec as is, that's fine though.

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/migrateGeo2 branch 3 times, most recently from 76af3ec to d776771 Compare February 26, 2026 22:24
…ols and night mode support active in dark mode

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5893.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@AndyScherzinger
Copy link
Member Author

In landscape mode there could be some space saved by not making the "Share location" box full width but keeping some space for the zoom and location buttons.

@jancborchardt Added with the last push 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants