Skip to content

refactor: Notifier#889

Draft
joshtrichards wants to merge 3 commits into
masterfrom
jtr/refactor-notifier
Draft

refactor: Notifier#889
joshtrichards wants to merge 3 commits into
masterfrom
jtr/refactor-notifier

Conversation

@joshtrichards

Copy link
Copy Markdown
Member

Some refactoring + swap out of InvalidArgumentException() with UnknownNotificationException() where appropriate

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards

joshtrichards commented Jul 11, 2024

Copy link
Copy Markdown
Member Author

I guess we should change the label provided to setLabel() to not be the translated one too... it may fix #877

Refs:
nextcloud/spreed#11610
nextcloud/server#43691

Signed-off-by: Josh <josh.t.richards@gmail.com>
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant