Skip to content

feat(upload): Add hidden admin configs for default upload choices - #20317

Merged
Antreesy merged 3 commits into
mainfrom
feat/19616/upload-choices-admin-config
Nov 16, 2026
Merged

Antreesy merged 3 commits into
mainfrom
feat/19616/upload-choices-admin-config

Conversation

@Antreesy

Copy link
Copy Markdown
Contributor

☑️ Resolves

occ config:app:set spreed attachments_allow_update --value=true
occ config:app:set spreed attachments_skip_compression --value=true

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the ☃️ Next Major (36) milestone Nov 13, 2026
@Antreesy Antreesy self-assigned this Nov 13, 2026
@Antreesy Antreesy added enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings AI assisted This PR contains AI-assisted commits labels Nov 13, 2026
@Antreesy

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@github-actions

Copy link
Copy Markdown
Contributor

OpenAPI changes

Breaking changes

None

New Endpoints: None

Deleted Endpoints: None

Modified Endpoints: 1

Show changes
GET /ocs/v2.php/apps/spreed/api/{apiVersion}/room/{token}/capabilities
- Responses changed
  - Modified response: 200
    - Content changed
      - Modified media type: application/json
        - Schema changed
          - Properties changed
            - Modified property: ocs
              - Properties changed
                - Modified property: data
                  - Property 'AnyOf' changed
                    - Modified schema: #/components/schemas/Capabilities
                      - Properties changed
                        - Modified property: config
                          - Properties changed
                            - Modified property: attachments
                              - Required changed
                                - New required property: allow-update
                                - New required property: skip-compression
                              - Properties changed
                                - New property: allow-update
                                - New property: skip-compression

@Antreesy
Antreesy merged commit 64291ff into main Nov 16, 2026
75 checks passed
@Antreesy
Antreesy deleted the feat/19616/upload-choices-admin-config branch November 16, 2026 09:38
@SystemKeeper

SystemKeeper commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Might be just me, but I don't like the naming here tbh. attachments_allow_update indicates to me that I can dis-allow updating of attachments, not that it is a default setting? Similar for attachments_skip_compression.

Would also need to be respected in the mobile clients then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(sharing): Add admin setting to default "Allow editing of uploaded files" toggle to enabled

3 participants