Skip to content

fix(appinfo): properly type info parser and app manager for appinfo.xml types#60066

Open
susnux wants to merge 4 commits intomasterfrom
fix/type-app-info
Open

fix(appinfo): properly type info parser and app manager for appinfo.xml types#60066
susnux wants to merge 4 commits intomasterfrom
fix/type-app-info

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented May 2, 2026

Summary

  • Added type definitions for parsed appinfo.xml
  • Small changes to simply typing (sanitation belongs to parsing not apply l10n!)
  • Added tests cases to ensure shape of parsing results

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added this to the Nextcloud 34 milestone May 2, 2026
@susnux susnux added the technical debt 🧱 🤔🚀 label May 2, 2026
@susnux susnux force-pushed the fix/type-app-info branch from 0253011 to fbdee4f Compare May 2, 2026 22:13
susnux added 4 commits May 3, 2026 00:18
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/type-app-info branch from 02a08c0 to e3044a3 Compare May 2, 2026 22:18
@susnux susnux added the 3. to review Waiting for reviews label May 2, 2026
@susnux susnux marked this pull request as ready for review May 3, 2026 09:54
@susnux susnux requested review from a team, come-nc and skjnldsv as code owners May 3, 2026 09:54
@susnux susnux requested review from Altahrim, CarlSchwan, leftybournes, provokateurin and salmart-dev and removed request for a team May 3, 2026 09:54
Comment thread apps/files_sharing/appinfo/info.xml
@susnux susnux requested a review from come-nc May 4, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants