Keep scroll position when dismissing a notification#3200
Open
jancborchardt wants to merge 1 commit into
Open
Conversation
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Collaborator
|
A bit hacky If I'm not mistaken, focus-trap should keep somewhere in memory the list of all tabbable nodes, and correctly handle it on losing one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking the Dismiss button on a notification, the list jumps to the top. This is especially annoying with a long list of notifications.
There should be no jump, only the nice short animation when dismissing the notification.
Seemingly regression from #2959
Before: jumps to top on dismissing notification
Screencast.From.2026-07-15.18-23-54.webm
After: no jump
Screencast.From.2026-07-15.18-19-55.webm
🤖 AI (if applicable)