Add null check before saving image to prevent panic#98
Merged
newfla merged 1 commit intonewfla:mainfrom Mar 25, 2026
Merged
Conversation
newfla
approved these changes
Mar 25, 2026
Owner
|
LGTM! Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an error check to handle out-of-memory (OOM) and other image generation errors in the
gen_img_maybe_progressfunction. The function now returns an error if the generated image data is null, preventing further processing or saving of invalid images.Error handling improvements:
DiffusionError::Forwardifimg.datais null, which can occur on OOM or other generation errors, ensuring invalid images are not saved or processed further ingen_img_maybe_progress(src/api.rs).