Ciena SAOS/10 ConfigParser Support #779
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
architekture
commented
Jan 15, 2026
architekture
commented
- Added CienaConfigParser class. This class supports both SAOS and SAOS10 devices.
- Added parser and compliance testing for both network drivers.
- Updated the compliance.py and lib_mapper.py files to include parser-to-driver mappings.
- Updated docs as required.
- Created issue 778 and referenced in change fragment as required.
- Ran feature branch through Ruff for formatting compliance.
architekture
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
…e is now passing Pylint.
jeffkala
approved these changes
Jan 16, 2026
jeffkala
reviewed
Jan 16, 2026
| "cannot_parse": true, | ||
| "compliant": false, | ||
| "extra": "system shell banner add banner login line \"*** THIS IS A LOGIN BANNER ***\"", | ||
| "intended": "system shell banner create banner login line \"*******************************************************************************\"\nsystem shell banner add banner login line \"*** THIS IS A LOGIN BANNER MESSAGE ***\"\nsystem shell banner add banner login line \"*******************************************************************************\"", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "intended": "system shell banner create banner login line \"*******************************************************************************\"\nsystem shell banner add banner login line \"*** THIS IS A LOGIN BANNER MESSAGE ***\"\nsystem shell banner add banner login line \"*******************************************************************************\"", | |
| "intended": "system shell banner create banner login line \"*******************************************************************************\"\nsystem shell banner add banner login line \"*** DEMONSTRATE A NON-MATCHING BANNER ***\"\nsystem shell banner add banner login line \"*******************************************************************************\"", |
| virtual-switch create vs MGMT-VS | ||
| virtual-switch create vs OPS-VS | ||
| system shell banner create banner login line "*******************************************************************************" | ||
| system shell banner add banner login line "*** THIS IS A LOGIN BANNER MESSAGE ***" |
Collaborator
There was a problem hiding this comment.
Suggested change
| system shell banner add banner login line "*** THIS IS A LOGIN BANNER MESSAGE ***" | |
| system shell banner add banner login line "*** DEMONSTRATE A NON-MATCHING BANNER ***" |
| "compliant": false, | ||
| "extra": "system shell banner add banner login line \"*** THIS IS A LOGIN BANNER ***\"", | ||
| "intended": "system shell banner create banner login line \"*******************************************************************************\"\nsystem shell banner add banner login line \"*** THIS IS A LOGIN BANNER MESSAGE ***\"\nsystem shell banner add banner login line \"*******************************************************************************\"", | ||
| "missing": "system shell banner add banner login line \"*** THIS IS A LOGIN BANNER MESSAGE ***\"", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "missing": "system shell banner add banner login line \"*** THIS IS A LOGIN BANNER MESSAGE ***\"", | |
| "missing": "system shell banner add banner login line \"*** DEMONSTRATE A NON-MATCHING BANNER ***\"", |
itdependsnetworks
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.