Skip to content

[NAE-2410] Add missing view role support for engine processes#434

Merged
machacjozef merged 1 commit intorelease/6.4.3from
NAE-2410
Apr 23, 2026
Merged

[NAE-2410] Add missing view role support for engine processes#434
machacjozef merged 1 commit intorelease/6.4.3from
NAE-2410

Conversation

@renczesstefan
Copy link
Copy Markdown
Member

@renczesstefan renczesstefan commented Apr 20, 2026

Description

Implements NAE-2410

Dependencies

No new dependencies were introduced

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

This was tested manually and with unit tests.

Test Configuration

Name Tested on
OS macOS Tahoe 26.3
Runtime Java 21
Dependency Manager Maven 3.9.9n
Framework version Spring Boot 3.4.4
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @machacjozef
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Summary by CodeRabbit

  • Bug Fixes
    • Enabled view access for the default user role in item settings, case view settings, and task view settings screens. Users with the default role can now properly access these configuration interfaces.

Added `<roleRef>` entries for the default role with `view` logic in multiple sections of `preference_item.xml`. This ensures the "default" role has appropriate view permissions for these configurations.
@renczesstefan renczesstefan self-assigned this Apr 20, 2026
@renczesstefan renczesstefan added the bugfix A change that fixes a bug label Apr 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b5bbac5d-d511-4f9b-ae00-341f404d9de6

📥 Commits

Reviewing files that changed from the base of the PR and between 3a415fe and f0995ba.

📒 Files selected for processing (1)
  • src/main/resources/petriNets/engine-processes/preference_item.xml

Walkthrough

This PR adds default role view permissions to three UI transitions in the preference_item Petri net configuration file. A default roleRef with view permission is inserted into item_settings, case_view_settings, and task_view_settings transitions without modifying existing role permissions.

Changes

Cohort / File(s) Summary
Default Role Permissions
src/main/resources/petriNets/engine-processes/preference_item.xml
Added default role roleRef with view permission to three UI transitions: item_settings, case_view_settings, and task_view_settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

Extra Small

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding view role support for engine processes in preference_item.xml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@machacjozef machacjozef merged commit 2bc5945 into release/6.4.3 Apr 23, 2026
7 checks passed
@machacjozef machacjozef deleted the NAE-2410 branch April 23, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes a bug Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants