feat: create Pulse section for bi-weekly community & ecosystem updates#44
Closed
linnnsss wants to merge 7 commits intonervosnetwork:masterfrom
Closed
feat: create Pulse section for bi-weekly community & ecosystem updates#44linnnsss wants to merge 7 commits intonervosnetwork:masterfrom
linnnsss wants to merge 7 commits intonervosnetwork:masterfrom
Conversation
|
@linnnsss is attempting to deploy a commit to the cryptape Team on Vercel. A member of the Team first needs to authorize it. |
RetricSu
requested review from
RetricSu and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Pulse” blog category to publish bi-weekly community/ecosystem updates alongside existing Blog and Devlog content.
Changes:
- Adds a new
pulsePostscontent collection andpulseloader sourcing fromcontent/pulse/. - Introduces a dedicated Pulse post route at
/blog/pulse/[id]and merges Pulse posts into the main blog listing. - Extends shared blog post typing and adds a “Pulse” filter option in the blog UI.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| source.config.ts | Defines a new pulsePosts collection schema for content/pulse. |
| lib/source.ts | Exposes a new pulse loader with /blog/pulse base URL. |
| content/pulse/issue-01.md | Adds the first Pulse issue post content. |
| app/blog/type.ts | Extends BlogPost.type union to include "pulse". |
| app/blog/pulse/[id]/page.tsx | Adds Pulse post page rendering + static params + metadata. |
| app/blog/page.tsx | Loads Pulse posts server-side and merges them into the blog list. |
| app/blog/BlogClientFilter.tsx | Adds “Pulse” category and routes Pulse links to /blog/pulse/.... |
Comments suppressed due to low confidence (1)
app/blog/BlogClientFilter.tsx:1
- The ternary chain is malformed: line 22 begins with
? allPosts.filter(...)without a preceding condition (it looks likeselectedCategory === "Article"was removed/mis-indented). This will not compile and breaks filtering logic. Re-introduce the missing condition or refactor to a clearswitch/ifchain to avoid this class of error.
"use client";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/blog/pulse/[id]/page.tsx
Outdated
Comment on lines
+7
to
+13
| interface BlogPostProps { | ||
| params: Promise<{ slug: string }>; | ||
| } | ||
|
|
||
| export default async function BlogPostPage({ params }: BlogPostProps) { | ||
| const { id } = await params; | ||
| const page = pulse.getPage([id]); |
app/blog/pulse/[id]/page.tsx
Outdated
Comment on lines
+22
to
+23
| // Use today's date if no date is provided | ||
| const postDate = page.data.date || new Date().toISOString().split('T')[0]; |
Comment on lines
+54
to
+60
| <time className="font-mono"> | ||
| {new Date(postDate).toLocaleDateString('en-US', { | ||
| year: 'numeric', | ||
| month: 'long', | ||
| day: 'numeric', | ||
| })} | ||
| </time> |
app/blog/pulse/[id]/page.tsx
Outdated
Comment on lines
+128
to
+134
| // Generate static params for all blog posts | ||
| export async function generateStaticParams() { | ||
| const pages = pulse.getPages(); | ||
| return pages.map((page) => ({ | ||
| id: page.slugs[0], | ||
| })); | ||
| } |
app/blog/BlogClientFilter.tsx
Outdated
Comment on lines
44
to
50
| <Link href={`/blog/pulse/${post.id}`} className="block"> | ||
| {children} | ||
| </Link> | ||
| ); | ||
| } else { | ||
| return ( | ||
| <Link href={`/blog/p/${post.id}`} className="block"> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
build failed on vercel: 16:51:36.566
16:51:36.763
[MDX] updated map file in 56.36571500000002ms
16:51:36.777
Creating an optimized production build ...
16:51:52.403
✓ Compiled successfully in 15.0s
16:51:52.408
Linting and checking validity of types ...
16:51:56.665
Failed to compile.
16:51:56.665
16:51:56.666
app/blog/pulse/[id]/page.tsx
16:51:56.666
Type error: Type 'PulsePostProps' does not satisfy the constraint 'PageProps'.
16:51:56.666
Types of property 'params' are incompatible.
16:51:56.666
Type '{ id: string; }' is missing the following properties from type 'Promise<any>': then, catch, finally, [Symbol.toStringTag]
16:51:56.666
16:51:56.692
Next.js build worker exited with code: 1 and signal: null
16:51:56.754
ELIFECYCLE Command failed with exit code 1.
16:51:56.776
Error: Command "pnpm run build" exited with 1
|
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new Pulse category to the blog to highlight community innovations and ecosystem contributions. While the DevLog focuses on internal engineering progress, Pulse is designed to showcase external builder activity around Fiber.
Key Changes:
Note: This is a Draft PR for initial feedback from the working group.