Skip to content

fix(ci): align npm to packageManager to unblock npm ci #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nerdchanii merged 1 commit into from
Aug 10, 2026
Merged

fix(ci): align npm to packageManager to unblock npm ci #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,15 @@ jobs:
react-version: [18, 19]
steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v6
- uses: actions/setup-node@v7

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep setup-node on an existing major

actions/setup-node@v7 does not identify a released action version; this repository's Dependabot history upgraded setup-node to the available v6 while its other workflows also remain on v6. Consequently, every CI matrix job will fail while resolving the action, before the new npm-alignment step can run, so keep this reference on v6 unless a real v7 release is available.

Useful? React with 👍 / 👎.

with:
node-version: 20
cache: npm
# package.json declares packageManager: npm@11.12.1. The runner ships npm
# 10.x, whose `npm ci` misreads the npm-11 lockfile (false "react@18.3.1
# missing"). Pin npm to the declared version before installing.
- name: Align npm to packageManager
run: npm install -g npm@11.12.1
Comment on lines +25 to +26

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align npm in the Pages workflow too

On every push to main, .github/workflows/pages.yml still selects Node 20 and immediately runs npm ci without upgrading its bundled npm 10.x. Because that job consumes the same npm-11-generated lockfile identified here as incompatible with npm 10, the Pages deployment will continue failing before npm run docs:build; apply the package-manager alignment to that workflow as well.

Useful? React with 👍 / 👎.

- run: npm ci
- run: npm install --no-save react@${{ matrix.react-version }} react-dom@${{ matrix.react-version }}
- run: npm run lint
Expand Down