fix: render full nebariapp.auth block via toYaml passthrough - #153
Closed
aktech wants to merge 2 commits into
Closed
fix: render full nebariapp.auth block via toYaml passthrough#153aktech wants to merge 2 commits into
aktech wants to merge 2 commits into
Conversation
The hand-rendered auth block covered 7 of the operator's AuthConfig fields and silently dropped the rest (groups, issuerURL, denyRedirect, spaClient, deviceFlowClient, clientSecretRef, keycloakConfig). Render the whole map like the routing block; defaults stay in values.yaml.
Member
|
Superseded by #225. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hand-rendered auth block dropped 7 AuthConfig fields (groups, issuerURL, denyRedirect, spaClient, deviceFlowClient, clientSecretRef, keycloakConfig); now the whole map passes through like routing, with defaults staying in values.yaml. Render test covers the previously-dropped fields and the zero-config defaults.
Closes #112, closes #57 (duplicate).