doesFileExist_ == True for broken symlinks#835
Open
1inguini wants to merge 1 commit intondmitchell:masterfrom
Open
doesFileExist_ == True for broken symlinks#8351inguini wants to merge 1 commit intondmitchell:masterfrom
1inguini wants to merge 1 commit intondmitchell:masterfrom
Conversation
I wanted pass the symlink to `produces`, intending to make the target file of the symlink afterwards, but got error: `Files declared by produces not produced:`.
Owner
|
Interesting - Shake doesn't really think about or know about symlinks in a meaningful way, and little of the design has considered them. Should symlinks be OK for directories? I'm inclined to say we merge this, and accept that it's approximate rather than precise, since designing in symlinks from the beginning is a lot of work. But on the fence. Curious if anyone else has opinions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted pass the symlink to
produces, intending to make the target file of the symlink afterwards, but got error:Files declared by produces not produced:.This pull request will let me
producesbroken symlink.