Dev#14
Open
dcutullic wants to merge 6 commits into
Open
Conversation
… player release finger. Add a reset button to launch another choose session
|
It may be more worth it to fork. @ndleyton does not appear active on GitHub. |
Owner
|
Hi! I'm so sorry. I've been through a lot and left my github projects for a while. I'll check it out right away, thanks! Also, I'll try to revive this project given the quarantine, if you have any more suggestions |
Owner
|
HI! I've tried it and I think it's a bit counterintuitive how nothing changes when you take off your fingers. Would you be fine with the results showing up up until all fingers are gone? @dcutullic |
|
Having the selection stick and implementing a way to reset it afterward would be a little more helpful (as described by @dcutullic), I think. If my finger's in the way I can't always see what the selection was in the first place. |
Author
|
Hi,
Thanks for your response.
I think it's a good thing than the results don't disappear even when all
fingers are gone.
I'm agree it could be counterintuitive, maybe it's possible to display a
popup to incite to click on the reset button. Or flash briefly the reset
button when all fingers are gone.
I will develop these improvements and send you an other version in few days.
I'm thinking about some others improvements : dices pools, specific dives
(with pictures), game score log, bigger score display.
Le jeu. 9 avr. 2020 à 21:48, EmberHeartshine <notifications@github.com> a
écrit :
… Having the selection stick and implementing a way to reset it afterward
would be a little more helpful, I think.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AONPUIZDW4TIBVTOCWM37CTRLYRBFANCNFSM4KN5QMLQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use your application to choose player's position but when a player release finger order is lost.
I added some code to keep display of selected players even if any player release finger.
Added a reset button to launch another choose session