Conversation
itables.options is now an instance of a ModuleType subclass that checks the option name and type on assignment, so that a typo in an option name, or an option with an unexpected type, is reported at the assignment itself rather than (possibly much later) when a table is rendered. The options passed to e.g. show are now checked before itables transforms them, so that the warning quotes the option as the user wrote it, and every item of a collection is now checked rather than just the first one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation. A conda package is also available for easy installation: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 95.20% 95.22% +0.02%
==========================================
Files 59 59
Lines 3668 3710 +42
==========================================
+ Hits 3492 3533 +41
- Misses 176 177 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itables.options is now an instance of a ModuleType subclass that checks the option name and type on assignment, so that a typo in an option name, or an option with an unexpected type, is reported at the assignment itself rather than (possibly much later) when a table is rendered.
The options passed to e.g. show are now checked before itables transforms them, so that the warning quotes the option as the user wrote it, and every item of a collection is now checked rather than just the first one.