Add a "🔒" hint to untrusted notebooks - #606
Merged
Merged
Conversation
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation. A conda package is also available for easy installation: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 95.22% 95.23%
=======================================
Files 59 59
Lines 3710 3716 +6
=======================================
+ Hits 3533 3539 +6
Misses 177 177 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static preview's small, linked "ⓘ" marker introduced in v2.9.0 is now preceded by a "🔒" hint specifically when the notebook you're viewing isn't trusted - explaining that trusting it will restore the interactive table. It's wrapped in a
<noscript>element so it only shows up in that actionable case: it stays hidden once the notebook is trusted, and on read-only renders (e.g. GitHub's.ipynbpreview) where trusting isn't available anyway.