Skip to content

Align ColumnControl search controls under Quarto Bootstrap theme#557

Open
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-columncontrol-alignment-issue
Open

Align ColumnControl search controls under Quarto Bootstrap theme#557
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-columncontrol-alignment-issue

Conversation

Copilot AI commented May 16, 2026

Copy link
Copy Markdown
Contributor

When rendering itables in Quarto with Bootstrap enabled, columnControl search dropdown controls can wrap unexpectedly, which misaligns the search icon/select pair and breaks the date/search control layout. This PR applies a narrow CSS override so ColumnControl search controls keep a single-row layout in Bootstrap contexts.

  • CSS: prevent ColumnControl search-row wrapping

    • Updated packages/dt_for_itables/src/index.css with a targeted rule for ColumnControl dropdown search containers:
    div.dtcc-dropdown div.dtcc-search > div {
        flex-wrap: nowrap;
    }
    • Scope is intentionally limited to ColumnControl dropdown search rows to avoid side effects on other DataTables UI elements.
  • Regression guard for future CSS updates

    • Extended packages/dt_for_itables/test_index_css.py with an assertion that this rule remains present in the source CSS.
    • Keeps this Bootstrap/Quarto compatibility fix from being removed during future stylesheet edits.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.jsdelivr.net
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1181/chrome-linux/headless_shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AcceptCHFrame,AutoExpandDetailsElement,AvoidUnnecessaryBeforeUnloadCheckSync,CertificateTransparencyComponentUpdater,DestroyProfileOnBrowserClose,DialMediaRouteProvider,ExtensionManifestV2Disabled,GlobalMediaControls,HttpsUpgrades,Impro bin/sh w_df_type.md docs/py/options//usr/local/bin/npx git node (dns block)
    • Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1217/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1217/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Transl node_modules/@np/tmp/itables-ui/columncontrol-bootstrap.png an_be_selected.pnode show_index.py /home/REDACTED/.cascreenshot node (dns block)
  • www.unpkg.com
    • Triggering command: /home/REDACTED/.local/bin/pytest pytest -q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 16, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix columnControl elements misalignment in Quarto Align ColumnControl search controls under Quarto Bootstrap theme May 16, 2026
Copilot finished work on behalf of mwouts May 16, 2026 21:19
Copilot AI requested a review from mwouts May 16, 2026 21:19
@mwouts mwouts marked this pull request as ready for review May 17, 2026 07:08
@codecov-commenter

codecov-commenter commented May 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.25%. Comparing base (3098ec5) to head (18ac637).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   94.24%   94.25%           
=======================================
  Files          48       48           
  Lines        2727     2731    +4     
=======================================
+ Hits         2570     2574    +4     
  Misses        157      157           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 17, 2026

Copy link
Copy Markdown

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR is available as a wheel artifact 📦 for easy installation.
Download it here, unzip it and then run pip install itables-xxx.whl in the unzipped directory.

A conda package is also available for easy installation:
Download it here, and then run conda install itables-xxx.tar.bz2 in the directory where you downloaded the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quarto: columnControl elements are misaligned

3 participants