Conversation
Agent-Logs-Url: https://github.com/mvrl/QuARI/sessions/22c88cba-d21a-4b84-b08e-560fa0978893 Co-authored-by: jacobsn <984784+jacobsn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add sample dataset for evaluating ILIAS and INQUIRE
Fix ILIAS/INQUIRE evaluation workflow: configurable paths, format mismatch, and sample data generator
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users had no clear path to evaluate on ILIAS/INQUIRE:
compute_embeds.pyhad hardcoded researcher-specific paths,eval_retrieval.pysilently broke when loading distractor embeddings due to a key mismatch, and there was no way to test the pipeline without downloading large datasets.compute_embeds.py— remove hardcoded paths--shard_dirand--out_dirare now required CLI arguments (were hardcoded to/u/ericx003/data/ilias/yfcc100mand./yfcc_embeds)eval_retrieval.py— fix distractor loading format mismatchcompute_embeds.pywrites{"keys": ..., "embeddings": ...}but the distractor loader calleddata['image_embeddings'], causing aKeyErrorat eval time.Added
load_distractor_embeddings_from_dir()that accepts both formats:Explicit
.float()cast on distractor tensors sincecompute_embeds.pydefaults to fp16 storage.create_sample_dataset.py— new synthetic data generatorGenerates minimal WebDataset tar shards for smoke-testing the pipeline end-to-end without large downloads:
README.md— evaluation documentationExpanded evaluation section with a staged walkthrough (distractor embeddings → paired embeddings → retrieval eval) for both ILIAS and INQUIRE, plus a complete smoke-test example using
create_sample_dataset.py.