Migrate to GMA Next-Gen SDK by mmathieum · Pull Request #589 · mtransitapps/commons

mmathieum · 2026-02-24T13:14:13Z

https://developers.google.com/admob/android/next-gen/migration

gemini-code-assist · 2026-02-24T13:14:26Z

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates the migration to the Google Mobile Ads Next-Gen SDK. The core changes involve updating the ad dependency to the new module and version, alongside implementing specific exclusion rules to manage potential conflicts with older ad service libraries. This ensures the application leverages the latest advertising platform features and improvements, streamlining the integration process for future ad-related functionalities.

Highlights

GMA Next-Gen SDK Migration: The project has been updated to migrate to the Google Mobile Ads (GMA) Next-Gen SDK, as indicated by the changes in dependency versions and module names.
Dependency Updates: The gps-ads dependency version has been updated to 0.24.0-beta01 and its module path changed from com.google.android.gms:play-services-ads to com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk.
Dependency Exclusions: Exclusion rules have been added in the main application's build.gradle to prevent conflicts by excluding play-services-ads and play-services-ads-lite from configurations when isMainApp is true.

Changelog

gradle/libs.versions.toml
- Updated the gps-ads version from 25.0.0 to 0.24.0-beta01.
- Changed the gps-ads module from com.google.android.gms:play-services-ads to com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk.
shared/app-android/build.gradle
- Added a conditional block to exclude com.google.android.gms:play-services-ads and com.google.android.gms:play-services-ads-lite from all configurations when isMainApp is true.

Activity

No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request successfully migrates the project to the GMA Next-Gen SDK by updating the gps-ads version and module in gradle/libs.versions.toml and adding exclusion rules for the old play-services-ads dependencies in shared/app-android/build.gradle. The changes appear to align with the migration guide provided in the PR description. The exclusion rules are a good practice to prevent conflicts with the new SDK.

- mtransitapps/commons#589

gemini-code-assist

Code Review

This pull request migrates the project from the legacy Google Play Services Ads SDK to the GMA Next-Gen SDK. Key changes include updating the dependency module to ads-mobile-sdk, adding supporting libraries like Cronet and Tink, and excluding legacy ads artifacts in the build configuration. Review feedback identifies critical concerns: the Next-Gen SDK lacks mediation support, which will cause existing mediation adapters for Facebook, AppLovin, and Vungle to fail at runtime. Furthermore, the PR lacks the necessary source code import updates for the new package, and a comment in the version catalog needs to be updated to reflect the new SDK's characteristics.

gemini-code-assist · 2026-04-16T20:17:10Z

 material = { module = "com.google.android.material:material", version.ref = "material" }
 # adds WRITE_EXTERNAL_STORAGE, READ_PHONE_STATE...
-gps-ads = { module = "com.google.android.gms:play-services-ads", version.ref = "gps-ads" }
+gps-ads = { module = "com.google.android.libraries.ads.mobile.sdk:ads-mobile-sdk", version.ref = "gps-ads" }


The GMA Next-Gen SDK does not currently support mediation. However, the project still includes mediation adapters for Facebook (line 211), AppLovin (line 213), and Vungle (line 215). Since the legacy play-services-ads SDK is explicitly excluded in shared/app-android/build.gradle, these adapters will fail at runtime due to missing dependencies. Additionally, this migration requires updating all source code imports to the new package (com.google.android.libraries.ads.mobile), which is not reflected in this diff. If mediation is required, you should not migrate to the Next-Gen SDK at this time.

gemini-code-assist · 2026-04-16T20:17:10Z

+        exclude group: "com.google.android.gms", module: "play-services-ads"
+        exclude group: "com.google.android.gms", module: "play-services-ads-lite"


This global exclusion will cause the mediation adapters (Facebook, AppLovin, Vungle) to fail at runtime because they depend on the play-services-ads artifacts being excluded here. As the Next-Gen SDK does not support mediation yet, these adapters should be removed if you intend to proceed with this migration.

gemini-code-assist · 2026-04-16T20:17:10Z

@@ -189,7 +189,7 @@ androix-webkit = { module = "androidx.webkit:webkit", version.ref = "androidx-we
 androidx-workManager-runtime = { module = "androidx.work:work-runtime", version.ref = "androidx-workManager" }
 material = { module = "com.google.android.material:material", version.ref = "material" }
 # adds WRITE_EXTERNAL_STORAGE, READ_PHONE_STATE...


This comment is outdated. The GMA Next-Gen SDK is designed to be lightweight and privacy-centric, and it does not require these permissions.

Suggested change

# adds WRITE_EXTERNAL_STORAGE, READ_PHONE_STATE...

# GMA Next-Gen SDK

Migrate to GMA Next-Gen SDK

39f211b

mmathieum self-assigned this Feb 24, 2026

Update dependencies baseline

fd804af

gemini-code-assist bot reviewed Feb 24, 2026

View reviewed changes

mmathieum added a commit to mtransitapps/mtransit-for-android that referenced this pull request Feb 24, 2026

Migrate to GMA Next-Gen SDK

771418a

- mtransitapps/commons#589

mmathieum mentioned this pull request Feb 24, 2026

Migrate to GMA Next-Gen SDK mtransitapps/mtransit-for-android#121

Draft

mmathieum added the P3 ⏸️ Priority 3: Medium label Feb 24, 2026

mmathieum added 2 commits April 16, 2026 14:36

Update gps-ads version to 1.0.0

8e839f2

Merge branch 'master' into mm/gma_next_gen_sdk

23be6fd

mmathieum added the money 💰 monetisation (ads/subscriptions) label Apr 16, 2026

montransit and others added 3 commits April 16, 2026 18:38

Update dependencies baseline

a16d3fe

fix

ac21fe8

Update dependencies baseline

eb5d424

mmathieum marked this pull request as ready for review April 16, 2026 20:15

gemini-code-assist bot reviewed Apr 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to GMA Next-Gen SDK#589

Migrate to GMA Next-Gen SDK#589
mmathieum wants to merge 7 commits intomasterfrom
mm/gma_next_gen_sdk

mmathieum commented Feb 24, 2026

Uh oh!

gemini-code-assist bot commented Feb 24, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Apr 16, 2026

Uh oh!

gemini-code-assist bot Apr 16, 2026

Uh oh!

gemini-code-assist bot Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		exclude group: "com.google.android.gms", module: "play-services-ads"
		exclude group: "com.google.android.gms", module: "play-services-ads-lite"

	# adds WRITE_EXTERNAL_STORAGE, READ_PHONE_STATE...
	# GMA Next-Gen SDK

Conversation

mmathieum commented Feb 24, 2026

Uh oh!

gemini-code-assist bot commented Feb 24, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants