Conversation
Click for detailed source code test coverage reportTest coverage report for Technic CNC 87.49% in 11/14 files:Test coverage report for technic chests 45.06% in 6/6 files:Test coverage report for technic 71.03% in 97/97 files:Raw test runner output for geeks:CNC: Chests: Technic: |
This was
linked to
issues
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase to master before merging.
Closes #404 and #267
Alternative to #368
Preview: adds generic on_rotate function for machines which in turn improves generic screwdriver compatibility.
Not just MTG but any of the screwedriver mods compatible with MTG.
If concept gets approved I'll work on it a bit more, some machines would like to get some other related fixes and some should be handled a bit different ways although nothing really big there.
Resolves following stuff without taking away sonic screwdriver special use:
How it solves these issues?
There's configuration to disable sonic screwdriver altogether. Unless "special" functionality is wanted, sonic screwdriver isn't really needed if any of the MTG API compatible screwdrivers can be used to rotate machines.
Those that don't want special "rotate anything"-functionality can then just disable sonic screwdriver and use any MTG compatible screwdriver they prefer.