Skip to content

Improved email title #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IQAndreas wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improved email title #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
105d5b3
Moved variables outside of the `mail` function
IQAndreas Aug 12, 2012
4ac7125
Added `get_post_field`
IQAndreas Aug 12, 2012
7e6cef3
Added and applied `filter_name` and `filter_email`
IQAndreas Aug 12, 2012
835d290
Added commenter name to mail header
IQAndreas Aug 12, 2012
480abd9
Improved email title
IQAndreas Aug 16, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions comment_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ <h1>Post a comment</h1>
</p>
<form id="commentform" method="POST" action="{{site.url}}/commentsubmit.php">
<input type="hidden" name="post_id" value="{{page.id}}" />
<input type="hidden" name="post_title" value="{{ page.title | escape }}" />
<input type="hidden" name="return_url" value="{{site.url}}{{page.url}}" />
<table>
<tr>
Expand Down
42 changes: 32 additions & 10 deletions commentsubmit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@
// because that turns you into an open relay, and that's not cool.
$EMAIL_ADDRESS = "blogger@example.com";

// The subject of all blog comment e-mails. If you're running lots of these,
// you might want to customise it, or if you were running a generic comment
// handler you could take it out of the form, but really, who cares what your
// comment e-mails are titled, as long as you can recognise it?
$SUBJECT = "Blog comment received";

// The contents of the following file (relative to this PHP file) will be
// displayed after the comment is received. Customise it to your heart's
// content.
Expand All @@ -42,10 +36,38 @@
* HERE BE CODE
****************************************************************************/

function get_post_field($key, $defaultValue = "")
{
return (isset($_POST[$key]) && !empty($_POST[$key])) ? $_POST[$key] : $defaultValue;
}

function filter_name($input)
{
$rules = array( "\r" => '', "\n" => '', "\t" => '', '"' => "'", '<' => '[', '>' => ']' );
return trim(strtr($input, $rules));
}

function filter_email($input)
{
$rules = array( "\r" => '', "\n" => '', "\t" => '', '"' => '', ',' => '', '<' => '', '>' => '' );
return strtr($input, $rules);
}


$EMAIL_ADDRESS = filter_email($EMAIL_ADDRESS);
$COMMENTER_NAME = filter_name(get_post_field('name', "Anonymous"));
$POST_TITLE = get_post_field('post_title', "Unknown post");

$subject = "Comment from $COMMENTER_NAME on '$POST_TITLE'";

// NOTE: Uses the "blog owner's" email address for the "From:" field,
// not the email address of the commenter.
$headers = "From: $COMMENTER_NAME <$EMAIL_ADDRESS>\r\n";

$post_id = $_POST["post_id"];
unset($_POST["post_id"]);
$msg = "post_id: $post_id\n";
$msg .= "date: " . date($DATE_FORMAT) . "\n";
$message = "post_id: $post_id\n";
$message .= "date: " . date($DATE_FORMAT) . "\n";

foreach ($_POST as $key => $value) {
if (strstr($value, "\n") != "") {
Expand All @@ -56,10 +78,10 @@
// It's easier just to single-quote everything than to try and work
// out what might need quoting
$value = "'" . str_replace("'", "''", $value) . "'";
$msg .= "$key: $value\n";
$message .= "$key: $value\n";
}

if (mail($EMAIL_ADDRESS, $SUBJECT, $msg, "From: $EMAIL_ADDRESS"))
if (mail($EMAIL_ADDRESS, $subject, $message, $headers))
{
include $COMMENT_RECEIVED;
}
Expand Down