feat(back): Added structured logs when available in the list of logs …#9473
Open
benoitgoupilleau wants to merge 1 commit into
Open
feat(back): Added structured logs when available in the list of logs …#9473benoitgoupilleau wants to merge 1 commit into
benoitgoupilleau wants to merge 1 commit into
Conversation
benoitgoupilleau
force-pushed
the
feature/AddStructuredLogsInLinks
branch
from
321d8f2 to
f67608d
Compare
…for finished tasks
benoitgoupilleau
force-pushed
the
feature/AddStructuredLogsInLinks
branch
from
f67608d to
1c3b37f
Compare
| "queue", | ||
| "v1", | ||
| f"task/{{taskId}}/runs/{{runId}}/artifacts/{artifact_path}", | ||
| ).format(taskId=task_id, runId=run_id), |
Collaborator
There was a problem hiding this comment.
Is there a reason the variable substitution is not part of the f-string but an additional format call?
| name = artifact.get("name", "") | ||
| if name.endswith("_raw.log"): | ||
| logs.append(_ref("structured_log", name)) | ||
| return logs |
Collaborator
There was a problem hiding this comment.
Please check the frontend only see one log. When the perf team added one additional artifact to parse some time ago, the log buttons turned into menus because of that. This should be avoided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before being parsed, structured logs should be added to the list of logs for a job.
This change adds it to the list when it exists