Skip to content

Fixed hardcoded binary path in test - #2790

Merged
sylvestre merged 1 commit into
mozilla:mainfrom
ranger-ross:fix-tests-on-nightly
Aug 2, 2026
Merged

Fixed hardcoded binary path in test#2790
sylvestre merged 1 commit into
mozilla:mainfrom
ranger-ross:fix-tests-on-nightly

Conversation

@ranger-ross

Copy link
Copy Markdown
Contributor

I noticed nightly CI failed in #2789 due to the Cargo build-dir layout changes on nightly.

This PR fixes the failing test by replacing fn find_sccache_binary with CARGO_BIN_EXE_sccache.
To do this I needed to move the test from a unit test to an integration test so that Cargo would set the CARGO_BIN_EXE_* env var

@codecov-commenter

codecov-commenter commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.32%. Comparing base (c037e11) to head (fd8332b).

Files with missing lines Patch % Lines
tests/server.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
- Coverage   74.32%   74.32%   -0.01%     
==========================================
  Files          71       72       +1     
  Lines       40789    40772      -17     
==========================================
- Hits        30318    30304      -14     
+ Misses      10471    10468       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre
sylvestre merged commit ed0dec7 into mozilla:main Aug 2, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants