feat: Play nicely with HIP's --offload-compress. - #2788
Open
sjuxax wants to merge 1 commit into
Open
Conversation
HIP’s --offload-compress causes Clang’s -E output to be a binary compressed offload bundle beginning with CCOB. Direct/preprocessor mode treated those bytes as textual # line "file" markers. A coincidental \n# 1... sequence in the compressed payload made the parser search for a filename quote until EOF. sccache now recognizes the CCOB magic and disables direct include tracking for that invocation. It still hashes the preprocessor output and uses the normal cache path. Disclosure: this patch written by GPT-5.6 Sol.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2788 +/- ##
==========================================
- Coverage 74.32% 74.32% -0.01%
==========================================
Files 71 71
Lines 40789 40791 +2
==========================================
- Hits 30318 30316 -2
- Misses 10471 10475 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIP’s --offload-compress causes Clang’s -E output to be a binary compressed offload bundle beginning with CCOB. Direct/preprocessor mode treated those bytes as textual # line "file" markers. A coincidental \n# 1... sequence in the compressed payload made the parser search for a filename quote until EOF.
sccache now recognizes the CCOB magic and disables direct include tracking for that invocation. It still hashes the preprocessor output and uses the normal cache path.
Disclosure: this patch written by GPT-5.6 Sol.