RMST-502: add ADR with possible solutions for missing tombstones - #1477
Open
leplatrem wants to merge 2 commits into
Open
RMST-502: add ADR with possible solutions for missing tombstones#1477leplatrem wants to merge 2 commits into
leplatrem wants to merge 2 commits into
Conversation
Dexterp37
reviewed
Sep 1, 2026
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
Thank you for the comprehensive and well written ADR.
|
|
||
| Tags are files on disk and slow down git operations, so the export job deletes the ones older than 30 days (`TAGS_MAX_AGE_DAYS`). Clients coming with a `_since` timestamp that has no matching tag are redirected to the full changeset ([#1474](https://github.com/mozilla/remote-settings/pull/1474)). | ||
|
|
||
| A full changeset contains only the live records and has no tombstone. Therefore, if records were deleted in the meantime, these clients never learn about the deletions, and **clients that do not verify signatures silently keep obsolete records in their local data**. |
There was a problem hiding this comment.
For my ignorant understanding (and future onboarding), would you kindly add a link to some documentation (or add a brief explanation) of what a tombstone is in this context?
| A full changeset contains only the live records and has no tombstone. Therefore, if records were deleted in the meantime, these clients never learn about the deletions, and **clients that do not verify signatures silently keep obsolete records in their local data**. | ||
|
|
||
| Clients verifying signatures catch up on retry: the signature covers the live record set, so the extraneous records make verification fail, and the client wipes its local data and pulls again. | ||
| The Application-Service Rust client do have the signature verification feature, but it is not enabled on iOS or Android builds ([Bug 2063304](https://bugzilla.mozilla.org/show_bug.cgi?id=2063304)). |
There was a problem hiding this comment.
Do we know why it's not enabled? Is it because it's not working due to this?
alexcottner
approved these changes
Sep 1, 2026
alexcottner
left a comment
alexcottner
left a comment
Contributor
There was a problem hiding this comment.
I think we should do both A and E.
On the bright side, this does not impact any ESR clients. Impacted clients would correct once signature verification fails with an updated version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What we had in this ticket:
https://mozilla-hub.atlassian.net/browse/RMST-502
in an ADR form...