Custom Getter

[A-312]

fix: #313

example of custom getter :

convict.addGetter('default', (value, schema, stopPropagation) => schema._cvtCoerce(value));
getters.order.push('value');
convict.addGetter('env', function(value, schema, stopPropagation) {
  return schema._cvtCoerce(this.getEnv()[value]);
});
convict.addGetter('arg', function(value, schema, stopPropagation) {
  const argv = parseArgs(this.getArgs(), {
    configuration: {
      'dot-notation': false
    }
  });
  return schema._cvtCoerce(argv[value]);
}, true);

TODO :

• Add documentation ;
• Tests ;
• Coverage 100% ;
• Function to set getter order.
• Set : add argument to set value depending of value priority or top priority (--> I mean after default or after args)
• getOrigin function : get getter source.
• According to Include env var in validation error message #333 add getOrigin in validate errors. / fix: Include env var in validation error message #333

NB :
fix: #224 => with stopPropagation() in a customGetter. & fix: #261 :

convict.addGetter('env', function(value, schema, stopPropagation) {
  if (typeof this.getEnv()[value] !== "undefined") {
    stopPropagation();
  }
  return schema._cvtCoerce(this.getEnv()[value]);
}, true);

fix: #283

[coveralls]

Coverage decreased (-0.2%) to 99.805% when pulling 3ad8b5f on A-312:custom-getter into d263763 on mozilla:master.

[A-312]

I merged #347 in this one because some test don't work well. Some test don't check the throw message corresponding to the expected error. And without expected/actual in the errorlog, it's hard to understand the problem.

[A-312]

conf.sortGetters() is different of convict.sortGetters() (where conf = convict(schema)). The first will change only local config, and the second the global config but we have to do conf.refreshGetters() to apply global change in local config. We are able to set different getter order for each conf we have.

[A-312]

Ready :D

EDIT :
but based into mozilla:master branch 😕 I will rebase into 6.0.0 branch.

[A-312]

For the rebase into 6.0.0 branch. I think, i will make another PR and pick these commits in:

• baf738a
• 7c667f7
• 8b571e4
• c4f7ae4
• 0dc4d83

I will wait that #336, #347 and #352 is merged before rebase.

[A-312]

Rebased into #353