-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: add DataTable component (@fehmer) #7397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
d4cfd81 to
917e717
Compare
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
0386015 to
e307c44
Compare
e307c44 to
1e10edb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a SolidJS DataTable implementation based on TanStack Solid Table, including responsive column visibility and persistent sorting.
Changes:
- Add
@tanstack/solid-tabledependency (and lockfile updates). - Introduce new
DataTable,Table, andTableColumnHeaderUI components. - Add TanStack table column meta typing (breakpoint + cell attributes) and export
BreakpointKeyfor reuse.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks new TanStack table dependency and transitive updates. |
| frontend/package.json | Adds @tanstack/solid-table to frontend deps. |
| frontend/tsconfig.json | Adds an extra include entry for .d.ts (currently suspicious/redundant). |
| frontend/src/ts/types/tanstack-table.d.ts | Module augmentation for column meta (breakpoint, cellMeta). |
| frontend/src/ts/signals/breakpoints.ts | Exports BreakpointKey type for table column meta. |
| frontend/src/ts/components/ui/table/TableColumnHeader.tsx | New sortable column header button component. |
| frontend/src/ts/components/ui/table/Table.tsx | New styled table primitive components. |
| frontend/src/ts/components/ui/table/DataTable.tsx | New DataTable wiring sorting + responsive visibility + cell meta attributes. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| if={ | ||
| header.column.getCanSort() && | ||
| typeof header.column.columnDef.header === "string" | ||
| } |
Copilot
AI
Jan 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorting UI is gated on typeof columnDef.header === "string". If a sortable column provides a JSX/header renderer (common in TanStack), the column will be sortable in state but not clickable in the UI. Gate only on getCanSort() (and !header.isPlaceholder) and render the header label via flexRender(...) inside the button.
following https://www.solid-ui.com/docs/components/data-table