Skip to content

Conversation

@fehmer
Copy link
Member

@fehmer fehmer commented Jan 20, 2026

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 20, 2026
@socket-security
Copy link

socket-security bot commented Jan 20, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@fehmer fehmer force-pushed the feature/data-table branch 3 times, most recently from d4cfd81 to 917e717 Compare January 23, 2026 12:05
@fehmer fehmer marked this pull request as ready for review January 23, 2026 12:05
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 23, 2026
@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing waiting for update Pull requests or issues that require changes/comments before continuing labels Jan 23, 2026
@fehmer fehmer force-pushed the feature/data-table branch from 0386015 to e307c44 Compare January 25, 2026 19:21
@fehmer fehmer force-pushed the feature/data-table branch from e307c44 to 1e10edb Compare January 26, 2026 11:36
@Miodec Miodec requested a review from Copilot January 27, 2026 19:17
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a SolidJS DataTable implementation based on TanStack Solid Table, including responsive column visibility and persistent sorting.

Changes:

  • Add @tanstack/solid-table dependency (and lockfile updates).
  • Introduce new DataTable, Table, and TableColumnHeader UI components.
  • Add TanStack table column meta typing (breakpoint + cell attributes) and export BreakpointKey for reuse.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pnpm-lock.yaml Locks new TanStack table dependency and transitive updates.
frontend/package.json Adds @tanstack/solid-table to frontend deps.
frontend/tsconfig.json Adds an extra include entry for .d.ts (currently suspicious/redundant).
frontend/src/ts/types/tanstack-table.d.ts Module augmentation for column meta (breakpoint, cellMeta).
frontend/src/ts/signals/breakpoints.ts Exports BreakpointKey type for table column meta.
frontend/src/ts/components/ui/table/TableColumnHeader.tsx New sortable column header button component.
frontend/src/ts/components/ui/table/Table.tsx New styled table primitive components.
frontend/src/ts/components/ui/table/DataTable.tsx New DataTable wiring sorting + responsive visibility + cell meta attributes.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Jan 27, 2026
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 27, 2026
@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels Jan 27, 2026
@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 27, 2026
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 27, 2026
@Miodec Miodec requested a review from Copilot January 28, 2026 20:44
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment on lines 117 to 120
if={
header.column.getCanSort() &&
typeof header.column.columnDef.header === "string"
}
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting UI is gated on typeof columnDef.header === "string". If a sortable column provides a JSX/header renderer (common in TanStack), the column will be sortable in state but not clickable in the UI. Gate only on getCanSort() (and !header.isPlaceholder) and render the header label via flexRender(...) inside the button.

Copilot uses AI. Check for mistakes.
@Miodec Miodec merged commit 8ab345d into master Feb 2, 2026
13 checks passed
@Miodec Miodec deleted the feature/data-table branch February 2, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants