Repository navigation
make mcp server disabled by default if apiKey is set to prevent error if no publicUrl - #281
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Frontend MCP enablement can remain active when the router disables MCP, causing the regression assertion to fail.
Review effort: Lite
Findings: None
What changed in this PR
Updates MCP defaults so API-key deployments disable MCP unless explicitly enabled, preventing publicUrl errors.
Changes:
- Adjusts Express and frontend MCP enablement logic.
- Adds regression coverage.
- Updates documentation and TypeScript declarations.
| File | Summary |
|---|---|
test/mcpOAuth.test.js |
Tests API-key MCP defaults. |
README.md |
Documents updated MCP configuration. |
nest.d.ts |
Clarifies NestJS MCP options. |
index.d.ts |
Clarifies Express MCP options. |
frontend/index.js |
Generates frontend MCP configuration; enablement logic needs alignment. |
express.js |
Applies API-key-aware MCP defaults. |
docs/mcp-oauth.md |
Updates OAuth guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.