Skip to content

make mcp server disabled by default if apiKey is set to prevent error if no publicUrl - #281

Merged
vkarpov15 merged 1 commit into
mainfrom
vkarpov15/mcp-cleanup
Oct 6, 2026
Merged

vkarpov15 merged 1 commit into
mainfrom
vkarpov15/mcp-cleanup

Conversation

@vkarpov15

Copy link
Copy Markdown
Member

No description provided.

Copilot AI lite review requested due to automatic review settings October 6, 2026 21:25
@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
studio Building Building Preview Oct 6, 2026 9:25pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T21:26:17.830924Z 75fe6d9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Frontend MCP enablement can remain active when the router disables MCP, causing the regression assertion to fail.

Review effort: Lite
Findings: None

What changed in this PR

Updates MCP defaults so API-key deployments disable MCP unless explicitly enabled, preventing publicUrl errors.

Changes:

  • Adjusts Express and frontend MCP enablement logic.
  • Adds regression coverage.
  • Updates documentation and TypeScript declarations.
File Summary
test/​mcpOAuth.test.js Tests API-key MCP defaults.
README.md Documents updated MCP configuration.
nest.d.ts Clarifies NestJS MCP options.
index.d.ts Clarifies Express MCP options.
frontend/​index.js Generates frontend MCP configuration; enablement logic needs alignment.
express.js Applies API-key-aware MCP defaults.
docs/​mcp-oauth.md Updates OAuth guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@vkarpov15
vkarpov15 merged commit 96d19f6 into main Oct 6, 2026
31 checks passed

This branch was successfully deployed

1 active deployment
Preview — 75fe6d94 Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants