TEST(Dropdown): expose selected multi values to screen readers - #3407
Draft
Mordech wants to merge 1 commit into
Draft
TEST(Dropdown): expose selected multi values to screen readers#3407Mordech wants to merge 1 commit into
Mordech wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
📦 Bundle Size Analysis ✅ No bundle size changes detected. Unchanged Components
📊 Summary:
|
Mordech
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Dropdown multi-select accessibility so selected values are exposed to assistive technologies without using generated Downshift ids as spoken labels.
What changed
aria-describedby.aria-labelledby.aria-labelvalues.Pokémonlabel and Pokémon option names.Verification
yarn workspace @vibe/core test src/components/Dropdown/__tests__/Dropdown.test.tsxgit diff --checkyarn workspace @vibe/core lint(passes with existing warnings)I have read the Contribution Guide for this project.
Resolves #
Made with Cursor