fix(tests): Skip incompatible eip4895 eip4788 eip4825 tests - #37
Merged
Conversation
Co-Authored-By: Claude <claude-fable-5>
The ~3 MB tx exceeds the runloop 2 MB proposal byte limit. Co-Authored-By: Claude <claude-fable-5>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar approach to #24
Greptile Summary
This PR skips three groups of tests that are incompatible with Monad forks, following the same pattern as PR #24. The
eip4788andeip4895directories each gain apytest_generate_testshook that marks all enclosed testsnot_valid_for("MONAD_EIGHT", subsequent_forks=True), and theeip7825zero-byte calldata parametrize case gains amonad_runloop-conditional skip because filling it generates a ~3 MB transaction that exceeds the Monad runloop's 2 MB proposal limit.pytest_generate_testsblocks added to both directories, matching the implementation already present intests/prague/eip6110_deposits/conftest.py,tests/osaka/eip7594_peerdas/conftest.py, and several others.pytest.mark.monad_runloop(pytest.mark.skip(...))applied tozero_byte=Trueonly; theFalse(non-zero byte) case is unaffected and continues to run, matching the pattern already used intests/frontier/validation/test_transaction.py.Confidence Score: 5/5
Safe to merge — all three changes apply narrow, targeted skips with clear rationales and follow the existing patterns in the repo.
All three changes are additive skip annotations that do not alter test logic. The conftest hooks are identical copies of patterns already used in at least six other EIP directories. The monad_runloop-gated skip mirrors the usage in tests/frontier/validation/test_transaction.py and only triggers when the --monad-runloop fill flag is explicitly passed. The zero_byte=False parametrize case is unaffected, so test coverage for non-zero bytes is preserved.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[pytest collect] --> B{conftest.py\npytest_generate_tests?} B -- eip4788 / eip4895 --> C[add_marker: not_valid_for\nMONAD_EIGHT, subsequent_forks=True] C --> D[Test skipped for\nMonad forks] B -- other dirs --> E[No extra marker added] A --> F{eip7825\nzero_byte param?} F -- zero_byte=True --> G[monad_runloop mark\nwrapping pytest.mark.skip] G --> H{--monad-runloop\nflag passed?} H -- Yes --> I[skip applied:\ntx too large for 2 MB limit] H -- No --> J[Test runs normally] F -- zero_byte=False --> J%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[pytest collect] --> B{conftest.py\npytest_generate_tests?} B -- eip4788 / eip4895 --> C[add_marker: not_valid_for\nMONAD_EIGHT, subsequent_forks=True] C --> D[Test skipped for\nMonad forks] B -- other dirs --> E[No extra marker added] A --> F{eip7825\nzero_byte param?} F -- zero_byte=True --> G[monad_runloop mark\nwrapping pytest.mark.skip] G --> H{--monad-runloop\nflag passed?} H -- Yes --> I[skip applied:\ntx too large for 2 MB limit] H -- No --> J[Test runs normally] F -- zero_byte=False --> JReviews (1): Last reviewed commit: "test(eip7825): skip zero-byte full-calld..." | Re-trigger Greptile