Skip to content

fix dev container issues on 2.0.0#1238

Open
sloria wants to merge 5 commits intomoghtech:2.0.0from
sloria:fix-dev-container
Open

fix dev container issues on 2.0.0#1238
sloria wants to merge 5 commits intomoghtech:2.0.0from
sloria:fix-dev-container

Conversation

@sloria
Copy link

@sloria sloria commented Mar 10, 2026

fixes this error when installing frontend deps in the dev container:

error @vitejs/plugin-react@5.1.4: The engine "node" is incompatible with this module. Expected version "^20.19.0 || >=22.12.0". Got "20.12.2"    

also addresses an OOM when running yarn build via the Run Komodo task:

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory       

@sloria sloria force-pushed the fix-dev-container branch 2 times, most recently from a0f6330 to ff6fda7 Compare March 10, 2026 21:24
@sloria
Copy link
Author

sloria commented Mar 10, 2026

actually, this is only needed on the 2.0.0 branch. will rebase

edit: done

@sloria sloria force-pushed the fix-dev-container branch from ff6fda7 to f0964d7 Compare March 10, 2026 21:31
@sloria sloria changed the base branch from main to 2.0.0 March 10, 2026 21:31
@sloria sloria changed the title fix node version and yarn build in dev container fix dev container issues on 2.0.0 Mar 10, 2026
services:
dev:
image: mcr.microsoft.com/devcontainers/rust:1-1-bullseye
image: mcr.microsoft.com/devcontainers/rust:1-bookworm
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was necessary in order to compile core

// Use 'forwardPorts' to make a list of ports inside the container available locally.
"forwardPorts": [
5173,
9120,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for CORS, along with the envvars

@sloria sloria force-pushed the fix-dev-container branch from c0cba23 to 3fdc42b Compare March 10, 2026 23:28
KOMODO_SESSION_ALLOW_CROSS_SITE: true needed to properly run on Firefox
@sloria sloria force-pushed the fix-dev-container branch from 3fdc42b to 88abb92 Compare March 10, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant